sfraczek edited a comment on pull request #20430: URL: https://github.com/apache/incubator-mxnet/pull/20430#issuecomment-893520454
I like it the way Andrzej wrote addressing. I'm open to suggestions but I don't see any better obvious solution. Duplication might be removed in near future PR. I don't want to mess up things more right now because other work depends on it. Bert uses those optimizations. It is disabled by default. It should be enabled when we track down accuracy problem on other machine. Preferably after one more optimization which will be pushed when OneDNN is upgraded to newer version (zero point reorder is on public master available but not on current release). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
