bgawrych commented on a change in pull request #20533:
URL: https://github.com/apache/incubator-mxnet/pull/20533#discussion_r692685479
##########
File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc
##########
@@ -42,9 +42,10 @@ mkldnn::inner_product_forward::primitive_desc
GetFCFwdImpl(const MKLDNNFCFullPar
const NDArray* bias,
const
mkldnn::memory::desc& out_md) {
auto data_md = GetMemDesc(data);
- auto weight_md = full_param.mkldnn_param.quantized ? GetFCWeightDesc(weight,
mshadow::kInt8)
- : GetFCWeightDesc(weight);
- auto engine = CpuEngine::Get()->get_engine();
+ auto weight_md = full_param.mkldnn_param.quantized
+ ? GetFCWeightDesc(weight, data.shape()[0],
mshadow::kInt8)
+ : GetFCWeightDesc(weight, data.shape()[0]);
+ auto engine = CpuEngine::Get()->get_engine();
Review comment:
It only align variables that are one below another without additional
lines between. I moved engine to the top of the function and it's aligned now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
