cfRod commented on a change in pull request #20482:
URL: https://github.com/apache/incubator-mxnet/pull/20482#discussion_r699696406
##########
File path: src/operator/operator_common.h
##########
@@ -620,6 +620,10 @@ class OpSignature {
hash = hash * 2 + arr.dtype();
eles.push_back(arr.dtype());
AddSign(arr.shape());
+#if DNNL_AARCH64_USE_ACL == 1
+ auto ival = reinterpret_cast<const uint64_t>(arr.storage_handle().dptr);
+ AddSign(ival);
+#endif
Review comment:
I checked that this function (arr.IsMKLDNNData()) is called for mkldnn
blocked format types
https://github.com/apache/incubator-mxnet/blob/7e835a592da902066f2ccb0d74a78adc8e77fdb7/include/mxnet/ndarray.h#L714
and here
https://github.com/apache/incubator-mxnet/blob/7e835a592da902066f2ccb0d74a78adc8e77fdb7/src/operator/nn/mkldnn/mkldnn_base.cc#L309
which is not used for ACL builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]