ptrendx commented on a change in pull request #20331:
URL: https://github.com/apache/incubator-mxnet/pull/20331#discussion_r701326230
##########
File path: src/engine/threaded_engine_perdevice.cc
##########
@@ -103,7 +118,11 @@ class ThreadedEnginePerDevice : public ThreadedEngine {
MSHADOW_CATCH_ERROR(mshadow::SetDevice<gpu>(ctx.dev_id));
#endif
}
- this->ExecuteOprBlock(RunContext{ctx, nullptr, nullptr, false},
opr_block);
+ CallbackOnStart on_start =
this->CreateOnStart(ThreadedEngine::OnStartStatic,
+ opr_block);
+ CallbackOnComplete callback =
this->CreateCallback(ThreadedEngine::OnCompleteStatic,
+ opr_block);
Review comment:
Mechanism introduced in this PR is in addition to the dependency
tracking that already existed, and the OnCompleteStatic contains dependency
update code (so it has to be called from the GPU version as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
