barry-jin commented on pull request #20617: URL: https://github.com/apache/incubator-mxnet/pull/20617#issuecomment-930345475
> I noticed you remove the ASF header from the np files. Could you explain the rational? > > > The term "third-party work" refers to a work not submitted directly to the ASF by the copyright owner or owner's agent. This includes parts of a work submitted directly to the ASF for which the submitter is not the copyright owner or owner's agent. > > Do not modify or remove any copyright notices or licenses within third-party works. > > Make sure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution. > > Do not add the standard Apache License header to the top of third-party source files. > > Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience. > > The project's PMC should deal with major modifications/additions to third-party source files on a case-by-case basis. > > https://www.apache.org/legal/src-headers.html#3party > > As there are major modifications/additions to the source files to integrate with MXNet, ASF header was previously added. Of course we can revisit this decision and relicense. Can you document why? As stated in the MXNet1.9.0 rc7 [voting thread](https://lists.apache.org/thread.html/r5789f5d93716d9d710b855775e71e4892fd37e41338c70c0855958ad%40%3Cgeneral.incubator.apache.org%3E), np_einsum_op.cc, np_einsum_op-inl.h and np_einsum_path_op-inl.h are adapted from numpy and they should stay under original license. https://www.apache.org/legal/src-headers.html#3party ... 3. Do not add the standard Apache License header to the top of third-party source files. ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
