bartekkuncer commented on a change in pull request #20589:
URL: https://github.com/apache/incubator-mxnet/pull/20589#discussion_r719199515
##########
File path: src/operator/nn/mkldnn/mkldnn_deconvolution.cc
##########
@@ -83,14 +83,12 @@ std::shared_ptr<deconv_fwd_pd_t>
MKLDNNDeconvFwd::CreatePrimitiveDesc(
const auto get_out_size = [&pd]() { return pd->dst_desc().get_size(); };
while (!ddc.CheckImplSizeReq(get_data_size(), get_weights_size(),
get_out_size())) {
Review comment:
If you are certain of a better implementation actually being chosen
after imposing plain format to just one/two tensors then it should stay as is,
but if not I believe it would be better to have them all reshaped at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
