PawelGlomski-Intel commented on a change in pull request #20606:
URL: https://github.com/apache/incubator-mxnet/pull/20606#discussion_r721244150
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -527,13 +527,13 @@ def quantize_model(sym, arg_params, aux_params,
data_names=('data',),
return qsym, qarg_params, aux_params
-def quantize_model_mkldnn(sym, arg_params, aux_params, data_names=('data',),
- ctx=cpu(), excluded_sym_names=None,
excluded_op_names=None,
- calib_mode='entropy', calib_data=None,
num_calib_batches=None,
- quantized_dtype='int8', quantize_mode='smart',
- quantize_granularity='tensor-wise', logger=None):
+def quantize_model_dnnl(sym, arg_params, aux_params, data_names=('data',),
+ ctx=cpu(), excluded_sym_names=None,
excluded_op_names=None,
+ calib_mode='entropy', calib_data=None,
num_calib_batches=None,
+ quantized_dtype='int8', quantize_mode='smart',
+ quantize_granularity='tensor-wise', logger=None):
"""User-level API for generating a fusion + quantized model from a FP32
model
- w/ or w/o calibration with Intel MKL-DNN.
+ w/ or w/o calibration with Intel DNNL.
Review comment:
```suggestion
w/ or w/o calibration with oneDNN.
```
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -552,9 +552,9 @@ def quantize_model_mkldnn(sym, arg_params, aux_params,
data_names=('data',),
raise ValueError('currently only supports single ctx, while received
%s' % str(ctx))
if ctx.device_type != 'cpu':
raise ValueError(
- 'quantize_model_mkldnn only support Intel cpu platform with
MKL-DNN Backend')
+ 'quantize_model_dnnl only support Intel cpu platform with DNNL
Backend')
Review comment:
```suggestion
'quantize_model_dnnl only support Intel cpu platform with oneDNN
Backend')
```
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -552,9 +552,9 @@ def quantize_model_mkldnn(sym, arg_params, aux_params,
data_names=('data',),
raise ValueError('currently only supports single ctx, while received
%s' % str(ctx))
if ctx.device_type != 'cpu':
raise ValueError(
- 'quantize_model_mkldnn only support Intel cpu platform with
MKL-DNN Backend')
+ 'quantize_model_dnnl only support Intel cpu platform with DNNL
Backend')
- sym = sym.optimize_for(backend='MKLDNN_QUANTIZE')
+ sym = sym.optimize_for(backend='DNNL_QUANTIZE')
Review comment:
```suggestion
sym = sym.optimize_for(backend='ONEDNN_QUANTIZE')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
