agrabows opened a new pull request #20652:
URL: https://github.com/apache/incubator-mxnet/pull/20652


   ## Description ##
   Function concatenate() from module mxnet.numpy will now be executed by 
oneDNN primitives as it is done in module mxnet.ndarray. Additionally concat 
from mxnet.ndarray will gain numpy fuctionality which is flattening input 
arrays when parameter dim=None.
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], 
[FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] Code is well-documented
   
   ### Changes ###
   - [x] Merge NNVM_REGISTER_OP(_npi_concatenate) with 
NNVM_REGISTER_OP(concatenate)
   
   ## Comments ##
   It was possible to merge both ndarray and numpy concatenate operators into 
one NNVM_REGISTER_OP, additional functionality was added to ndarray concatenate 
by this process.
   Performance tests from mxnet profiler with 10 warmup runs and 50 test runs 
of this operator are given below:
   
![image](https://user-images.githubusercontent.com/59651240/136538384-76578db3-4731-4033-89ee-11e999596382.png)
   Numpy concatenate was about 9 times faster in those tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to