josephevans commented on a change in pull request #20709:
URL: https://github.com/apache/incubator-mxnet/pull/20709#discussion_r740555775
##########
File path: LICENSE
##########
@@ -324,14 +327,6 @@
3rdparty/dmlc-core/include/dmlc/blockingconcurrentqueue.h
include/dmlc/blockingconcurrentqueue.h (symlink to
3rdparty/dmlc-core/include/dmlc/blockingconcurrentqueue.h)
-
=======================================================================================
- Apache-2.0 license + 3-clause BSD license
-
=======================================================================================
-
- python/mxnet/onnx/mx2onnx/_export_onnx.py
- python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset12.py
- python/mxnet/onnx/mx2onnx/_op_translations/_op_translations_opset13.py
-
=======================================================================================
Apache-2.0 license + MIT License
Review comment:
OK, in order to make the licensing clear for this particular issue, I've
moved the single function (LayerNormCPUKernel) into it's own file
(`layer_norm_cpu.h`). This file is MIT-licensed, while the remaining code will
still be under the ASF-2.0 license.
##########
File path: licenses/LICENSE.blockingconcurrentqueue.txt
##########
@@ -0,0 +1,26 @@
+©2015-2016 Cameron Desrochers. Distributed under the terms of the simplified
+BSD license, available at the top of concurrentqueue.h.
+
+Uses Jeff Preshing's semaphore implementation (under the terms of its
+separate zlib license, embedded below).
+
+
+zlib license
Review comment:
This is part of TVM. This is the same way they include the license for
this file.
##########
File path: licenses/LICENSE.blockingconcurrentqueue.txt
##########
@@ -0,0 +1,26 @@
+©2015-2016 Cameron Desrochers. Distributed under the terms of the simplified
+BSD license, available at the top of concurrentqueue.h.
+
+Uses Jeff Preshing's semaphore implementation (under the terms of its
+separate zlib license, embedded below).
+
+
+zlib license
Review comment:
See https://github.com/apache/tvm/blob/main/LICENSE#L223-L226 and
https://github.com/apache/tvm/blob/main/licenses/LICENSE.blockingconcurrentqueue.txt
for references in TVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
