anko-intel commented on a change in pull request #20719:
URL: https://github.com/apache/incubator-mxnet/pull/20719#discussion_r742617292



##########
File path: ci/jenkins/Jenkins_steps.groovy
##########
@@ -174,7 +174,7 @@ def compile_unix_mkl_cpu(lib_name) {
 }
 
 def compile_unix_onednn_cpu(lib_name) {
-    return ['CPU: ONEDNN': {
+    return ['CPU: oneDNN': {

Review comment:
       please double check if "oneDNN" here works properly

##########
File path: NEWS.md
##########
@@ -26,7 +26,7 @@ MXNet Change Log
       * [CUDA Graphs](#cuda-graphs)
       * [CUDA 11 Support](#cuda-11-support)
       * [TensorRT](#tensorrt)
-      * [OneDNN](#onednn)
+      * [oneDNN](#onednn)

Review comment:
       I am not sure if "Change Log" should be changed. I suppose not

##########
File path: docs/static_site/src/pages/api/faq/large_tensor_support.md
##########
@@ -141,9 +141,9 @@ Backward pass is partially supported and not completely 
tested, so it is conside
 
 Not supported:
 
-* GPU and ONEDNN. 
+* GPU and oneDNN. 
 * Windows, ARM or any operating system other than Ubuntu
-* Any permutation of MXNet wheel that contains ONEDNN. 
+* Any permutation of MXNet wheel that contains oneDNN. 

Review comment:
       seems not to be valid. Please check and fix in separate PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to