mozga-intel commented on a change in pull request #20621: URL: https://github.com/apache/incubator-mxnet/pull/20621#discussion_r744617652
########## File path: src/operator/nn/dnnl/dnnl_stack.cc ########## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file dnnl_stack.cc + */ + +#include "./dnnl_base-inl.h" +#include "./dnnl_concat-inl.h" +#include "./dnnl_ops-inl.h" + +#include "../../tensor/matrix_op-inl.h" + +#if MXNET_USE_ONEDNN == 1 +namespace mxnet { +namespace op { + +bool SupportDNNLStack(const std::vector<NDArray>& inputs) { + if (inputs[0].dtype() != mshadow::kFloat32 && inputs[0].dtype() != mshadow::kBfloat16) + return false; + + int src_dtype = inputs[0].dtype(); + for (auto& arr : inputs) { + if (arr.dtype() != src_dtype) { + return false; + } + // DO not support zero-size tensors. + if (arr.shape().Size() == 0) + return false; + int ndim = arr.shape().ndim(); + if (ndim <= 0) + return false; + } + return true; +} + +void DNNLStackForward(const nnvm::NodeAttrs& attrs, + const OpContext& ctx, + const std::vector<NDArray>& in_data, + const std::vector<OpReqType>& req, + const std::vector<NDArray>& out_data) { + TmpMemMgr::Get()->Init(ctx.requested[concat_enum::kTempSpace]); + + const StackParam& param = dmlc::get<StackParam>(attrs.parsed); + const int axis = CheckAxis(param.axis, out_data[0].shape().ndim()); + const auto oshape = out_data[0].shape(); Review comment: Does the type of this out_data might be volatile? ~ [if no]: please use the type explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
