bgawrych commented on a change in pull request #20712:
URL: https://github.com/apache/incubator-mxnet/pull/20712#discussion_r752939510
##########
File path: src/operator/subgraph/dnnl/dnnl_subgraph_base-inl.h
##########
@@ -31,7 +31,7 @@ static inline bool SupportDNNLAttr(const
std::shared_ptr<NodeAttr>& node_attr) {
return (node_attr->dispatch_mode == DispatchMode::kFComputeEx) &&
(node_attr->itype[0] == mshadow::kFloat32 ||
node_attr->itype[0] == mshadow::kBfloat16) &&
- (ndim == 1 || ndim == 2 || ndim == 4 || ndim == 5);
+ (ndim >= 1 && ndim <= 5);
Review comment:
Yes, i don't see any reason why 3 should be ommited here - probably
someone missed it or there was some kind of not noted bug. All tests are
passing so I'm assuming it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
