bgawrych commented on a change in pull request #20759:
URL: https://github.com/apache/incubator-mxnet/pull/20759#discussion_r759934358



##########
File path: include/mxnet/op_attr_types.h
##########
@@ -348,6 +348,21 @@ using FAvoidQuantizeInput = std::function<bool (const 
NodeAttrs& attrs,
                                                 const size_t index,
                                                 const std::string 
quantize_granularity)>;
 
+/*!
+ * \brief Register a function to determine if the input of a quantized operator
+ * needs to be asymmetric quantized.

Review comment:
       done

##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -314,9 +326,20 @@ Graph QuantizeGraph(Graph &&src) {
               }
             }
 
-            ObjectPtr quantize_node = InsertNode("_contrib_quantize_v2",
-              e.node->attrs.name + suffix + "_quantize", new_node, 
mirror_entry);
-            quantize_node->attrs.dict["out_type"] = quantized_dtype;
+            // ObjectPtr quantize_node = InsertNode("_contrib_quantize_v2",

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to