piotrwolinski-intel commented on a change in pull request #20776:
URL: https://github.com/apache/incubator-mxnet/pull/20776#discussion_r773867587
##########
File path: src/operator/nn/dnnl/dnnl_pooling-inl.h
##########
@@ -172,27 +173,34 @@ inline bool DNNLRequireWorkspace(const PoolingParam&
param) {
}
typedef ParamOpSign<PoolingParam> DNNLPoolingSignature;
-void DNNLPoolingCompute(const OpContext& ctx,
- const PoolingParam& param,
- const NDArray& in_data,
- const OpReqType req,
- const NDArray& out_data,
- const NDArray* workspace,
- const bool use_adaptive_pooling);
-
-void DNNLPoolingGradCompute(const OpContext& ctx,
- const PoolingParam& param,
- const NDArray& out_grad,
- const NDArray& in_data,
- const NDArray* workspace,
- const OpReqType req,
- const NDArray& in_grad);
+
Review comment:
Because it is type declaration and for the readability purposes it is in
my opinion better for it to be separated. Of course if I'm not missing
convention or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
