anko-intel commented on a change in pull request #20713:
URL: https://github.com/apache/incubator-mxnet/pull/20713#discussion_r783076324
##########
File path: src/operator/numpy/np_elemwise_broadcast_op_sub.cc
##########
@@ -33,6 +33,10 @@
MXNET_OPERATOR_REGISTER_NP_BINARY_MIXED_PRECISION(_npi_subtract)
op::mshadow_op::minus,
op::mshadow_op::mixed_minus,
op::mshadow_op::mixed_rminus>)
+#if MXNET_USE_ONEDNN == 1
+ .set_attr<FComputeEx>("FComputeEx<cpu>",
NumpyBinaryOperatorComputeExCPU<op::mshadow_op::minus>)
Review comment:
What about mixed version? is it work properly for GPU if oneDNN is
enabled (default configuration). Could you check if there is any test for it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
