bgawrych commented on a change in pull request #20847:
URL: https://github.com/apache/incubator-mxnet/pull/20847#discussion_r792449419
##########
File path: src/operator/nn/dnnl/dnnl_convolution.cc
##########
@@ -116,10 +116,18 @@
std::shared_ptr<dnnl::convolution_forward::primitive_desc> GetConvFwdImpl(
// suboptimal kernel for computation that has the expected memory
size requirements
auto conv_pd =
std::make_shared<dnnl::convolution_forward::primitive_desc>(desc, attr, engine);
- while (conv_pd->dst_desc().get_size() != GetArraySize(output) ||
- conv_pd->src_desc().get_size() != GetArraySize(data) ||
- (!param.dnnl_param.quantized &&
- conv_pd->weights_desc().get_size() !=
GetArraySize(weights))) {
+ while (
+ conv_pd->dst_desc().get_size() != GetArraySize(output) ||
+ conv_pd->src_desc().get_size() != GetArraySize(data) ||
+ (!param.dnnl_param.quantized &&
+ conv_pd->weights_desc().get_size() != GetArraySize(weights)) ||
+ // With the upgrade of oneDNN to version 2.4+
+ //
tests/python/dnnl/subgraphs/test_conv_subgraph.py::test_pos_conv_add[True-data_shape1]
+ // started failing. Switching away from primitive with weight
dnnl::format_tag
+ // ABcd4b16a4b is in place to temporairly fix the issue until
full fix arrives.
+ // Tracking issue:
https://github.com/apache/incubator-mxnet/issues/20826.
Review comment:
```suggestion
// With the upgrade of oneDNN to version 2.4+
//
tests/python/dnnl/subgraphs/test_conv_subgraph.py::test_pos_conv_add[True-data_shape1]
// started failing. Switching away from primitive with weight
dnnl::format_tag
// ABcd4b16a4b in order to temporarily fix the issue until
full fix arrives.
// Tracking issue:
https://github.com/apache/incubator-mxnet/issues/20826.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
