[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20666: [v1.x][submodule] Upgrade oneDNN to v2.4.4

Thu, 27 Jan 2022 05:44:21 -0800 


anko-intel commented on a change in pull request #20666:
URL: https://github.com/apache/incubator-mxnet/pull/20666#discussion_r793615630



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -113,16 +113,28 @@ 
std::shared_ptr<mkldnn::convolution_forward::primitive_desc> GetConvFwdImpl(
       [&param, &data, &weights, &output, &attr](const 
mkldnn::convolution_forward::desc& desc) {
         auto engine = CpuEngine::Get()->get_engine();
         try {
-          // MKL-DNN introduced padded formats since 0.15 which require more 
memory
-          // compared to the actual size of the tensor. Currently, MKL-DNN 
operators
-          // still reuse memory from memory planning, so here we need to 
select a
-          // suboptimal kernel for computation that has the expected memory 
size requirements
+          // MKLDNN introduced padded formats since 0.15 which require more

Review comment:
       please keep  max line with  equal 100 in autoformater




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to