DickJC123 commented on pull request #20903: URL: https://github.com/apache/incubator-mxnet/pull/20903#issuecomment-1048999205
Regarding the ts.gluon.ai problem, since we want to reference the link once it works, my approach was to lean on them to fix the problem (see https://github.com/awslabs/gluon-ts/issues/1901). At this point, they have fixed the issue (at least to the point of removing the error). As proof of the fix, on a side PR of mine, without any link fixes, linkcheck now passes: https://github.com/apache/incubator-mxnet/runs/5299064848?check_suite_focus=true Are you willing to remove the link check fix from this PR, now that it is no longer needed? And regarding the Jinja2 import issue, I prefer the approach you've taken here- simpler than adding the MarkupSafe pinning that I explored. I vote for accepting this PR, and follow up with a different fix only if someone notices the docs are wrong because of the new Jinja2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
