anko-intel commented on a change in pull request #20928:
URL: https://github.com/apache/incubator-mxnet/pull/20928#discussion_r818401622



##########
File path: src/operator/random/shuffle_op.cc
##########
@@ -78,28 +78,37 @@ void ShuffleND(DType* const out,
   std::shuffle(index.begin(), index.end(), *prnd);
   if (reqT != kWriteInplace) {
     for (index_t i = 0; i < first_axis_len; ++i) {
-      auto j = index[i];
-      std::memcpy(out + stride * j, in + stride * i, stride_bytes);

Review comment:
       following error occurs after first comit:
   /work/mxnet/src/operator/random/shuffle_op.cc:82:18: error: 'void* 
memcpy(void*, const void*, size_t)' writing to an object of type 'class 
mshadow::half::half_t' with no trivial copy-assignment; use copy-assignment or 
copy-initialization instead [-Werror=class-memaccess]




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to