barry-jin commented on pull request #20933: URL: https://github.com/apache/incubator-mxnet/pull/20933#issuecomment-1059522890
> @szha @barry-jin This PR only changes the test to work with newer numpy versions by not testing out-of-bounds indexes (that were previously ignored,) and not testing negative indexes. Should there be any changes on the mxnet side to also now support negative indexes instead of ignoring them? I think so. For out-of-bounds indexes, we may need to add a warning or directly raise an error in MXNet side. For negative indexes, I think `mxnet.np.delete` supports negative indexes, but may not compatible with numpy>=1.19.0, if that's the case, we need to upgrade `delete` operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
