PawelGlomski-Intel commented on a change in pull request #20753:
URL: https://github.com/apache/incubator-mxnet/pull/20753#discussion_r823727815
##########
File path: python/mxnet/executor.py
##########
@@ -371,11 +371,7 @@ def copy_params_from(self, arg_params, aux_params=None,
allow_extra_params=False
for name, array in arg_params.items():
if name in self.arg_dict:
dst = self.arg_dict[name]
- if dst.dtype == np.dtype([('bfloat16', np.uint16)]):
- cast_array = ndarray.amp_cast(array, dtype=dst.dtype)
- cast_array.copyto(dst)
- else:
- array.astype(dst.dtype).copyto(dst)
+ array.astype(dst.dtype).copyto(dst)
Review comment:
Aren't `arg_params` expected to be MXNet NDArrays? If they can be
`numpy.ndarray`, then yes, this is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
