bgawrych commented on a change in pull request #20913:
URL: https://github.com/apache/incubator-mxnet/pull/20913#discussion_r823738415
##########
File path: src/ndarray/ndarray.cc
##########
@@ -605,36 +605,14 @@ void NDArray::Chunk::SetMKLMem(const mxnet::TShape&
shape, int dtype) {
dnnl::memory::dims dims;
// These are shapes supprted by DNNL.
- if (shape.ndim() >= 1 && shape.ndim() <= 6) {
+ if (shape.ndim() >= 1 && shape.ndim() <= 12) {
Review comment:
Can '12' be named by const variable? e.g. "const int MAX_ONEDNN_DIMS"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
