ptrendx commented on a change in pull request #20324:
URL: https://github.com/apache/incubator-mxnet/pull/20324#discussion_r827287773
##########
File path: src/operator/contrib/count_sketch.cu
##########
@@ -93,6 +93,9 @@ __global__ void sketch_backward_kernel(const int nthreads,
// only calculate gradient regarding x
// can also calculate gradient regarding s if needed
const int index = blockIdx.x * blockDim.x + threadIdx.x;
+ if (index >= nthreads) {
Review comment:
That test was breaking the CI for a looong time, thanks for the fix :-).
Could you search for the issues about it and close them once this is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
