DickJC123 commented on a change in pull request #20324:
URL: https://github.com/apache/incubator-mxnet/pull/20324#discussion_r827411921
##########
File path: src/operator/contrib/count_sketch.cu
##########
@@ -93,6 +93,9 @@ __global__ void sketch_backward_kernel(const int nthreads,
// only calculate gradient regarding x
// can also calculate gradient regarding s if needed
const int index = blockIdx.x * blockDim.x + threadIdx.x;
+ if (index >= nthreads) {
Review comment:
This was a 'tack on' commit that was also in an already merged PR
https://github.com/apache/incubator-mxnet/pull/20876, so it's part of master
now. Per your suggestion here, I've now closed the open issue mentioning
test_countsketch flakyness:
https://github.com/apache/incubator-mxnet/issues/10988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
