DickJC123 opened a new pull request #20965:
URL: https://github.com/apache/incubator-mxnet/pull/20965


   ## Description ##
   This PR supplies a missing check for extreme negative k values in the 
mxnet.numpy.eye() implementation.  I believe this was the reason why the 
array_api tests needed to be run with MXNET_ENABLE_CYTHON=0, since apparently 
Cython produced overflow errors for some eye() test cases where ctypes did not. 
 This PR re-enables Cython uniformly for both the centos and macosx jobs that 
perform the array_api testing.  This PR should resolve 
https://github.com/apache/incubator-mxnet/issues/20963 by supplying the root 
cause fix, not by disabling Cython as is discussed in the issue.
   
   FYI @barry-jin 
   
   ## Checklist ##
   ### Essentials ###
   - [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], 
[FEATURE], [DOC], etc)
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage
   - [X] Code is well-documented
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to