anko-intel commented on a change in pull request #20753:
URL: https://github.com/apache/incubator-mxnet/pull/20753#discussion_r828967576
##########
File path: src/serialization/cnpy.cc
##########
@@ -109,7 +109,7 @@ std::string dtype_descr(const TBlob& blob) {
case mshadow::kUint64:
return "'" MXNET_BYTEORDER "u8'";
case mshadow::kBfloat16:
- return "[('bfloat16', '" MXNET_BYTEORDER "u2')]";
+ return "'" MXNET_BYTEORDER "bfloat16'";
Review comment:
Agree, It shouldn't be dependant on order. So "b2" seems to me better
candidate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
