bartekkuncer commented on a change in pull request #20958:
URL: https://github.com/apache/incubator-mxnet/pull/20958#discussion_r832287930
##########
File path: src/operator/nn/dnnl/dnnl_act.cc
##########
@@ -70,9 +70,9 @@ bool SupportDNNLLeakyRelu(const LeakyReLUParam& param, const
NDArray& input) {
}
bool SupportQuantizedDNNLAct(const ActivationParam& param) {
- // TODO(zhennan): Add more activation type when dnnl supports.
- // Remove this when it's identity to SupportDNNLAct.
- return param.act_type == activation::kReLU;
+ // Although it is the same as SupportDNNLAct i left it here, so when new
activations
Review comment:
I understand what you mean but would still prefer this removed. I
believe that a developer will create separate function for more sophisticated
functions if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
