piotrwolinski-intel commented on PR #21046: URL: https://github.com/apache/incubator-mxnet/pull/21046#issuecomment-1141954192
> > > Why in two places you added "EliminateCommonNodes" but in one "EliminateCommonNodesPass"? > > > Do you think it is necessary to have these two as separate entities? Maybe it would be better to use just "EliminateCommonNodes" and add the "ON/OFF" flag there? > > > > > > Actually it is a mistake on my side, `EliminateCommonNodes` was used during my earlier attempts to make it work and I forgot to change it, so thank You very much for pointing this out! > > So now there are two separate passes "EliminateCommonNodes" and "EliminateCommonNodesPass"? Or the first one does not exist? Yes, the first does not exist and only `EliminateCommonNodesPass` is valid one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
