bartekkuncer commented on code in PR #21056: URL: https://github.com/apache/incubator-mxnet/pull/21056#discussion_r890972358
########## src/operator/nn/mkldnn/mkldnn_reshape.cc: ########## @@ -127,6 +127,8 @@ void MKLDNNReshapeForward(const nnvm::NodeAttrs& attrs, // For mkldnn non-supported input, it shouldn't hold mkldnn memory, so let's simply fallback to // naive implement. const int input_ndims = input.shape().ndim(); + CHECK(input.shape().Size() == output.shape().Size()) Review Comment: Is this condition valid also for 'generic' MXNet path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
