waytrue17 commented on PR #21182: URL: https://github.com/apache/mxnet/pull/21182#issuecomment-1441039832
> > Thanks for the fix! Shall we add a test to cover it? Maybe something like the example in #20959 > > To clarify @waytrue17, are you asking for the example in #20959 repackaged into a 'dataloader leak unittest'? Regarding a unittest targeting the segfault issue, do you know if the CI builds have horovod installed (a requirement)? Do we have multi-GPU testing in CI? Seems the CI installs horovod only in master at [here](https://github.com/apache/mxnet/blob/48d7f4af70015a559b20bc58aea037548c7e2658/ci/docker/runtime_functions.sh#L1061), and it was disabled due to some [hanging issue](https://github.com/apache/mxnet/blob/fc54fabe61573d0405b6ddead8c1501aedad3a11/ci/jenkins/Jenkinsfile_unix_gpu#L53). Approved the PR since we have verified the fix with local test. Lets bring it in and unblock the customers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
