eric-haibin-lin commented on a change in pull request #7082: Sparse Tensor:
request for reviews
URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r130523475
##########
File path: src/executor/attach_op_execs_pass.cc
##########
@@ -22,28 +23,39 @@ const OperatorProperty* OpPropGetOpProperty(const
NodeAttrs& attrs);
namespace exec {
-// forward executor
+// stateful compute executor
class StatefulComputeExecutor : public OpExecutor {
public:
- void Run(RunContext rctx) override {
+ void Run(RunContext rctx, bool is_gpu) override {
+ using namespace common;
+ // TODO(haibin) avoid repeating this if all inputs are already in
default-storage
op_ctx.run_ctx = rctx;
- fcompute_(state_, op_ctx, in_data_, req, out_data_);
+ in_data_.clear();
Review comment:
not anymore. Changed in https://github.com/eric-haibin-lin/mxnet/pull/134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
