piiswrong commented on a change in pull request #7322: add verification to
gluon dataset
URL: https://github.com/apache/incubator-mxnet/pull/7322#discussion_r131201378
##########
File path: python/mxnet/gluon/utils.py
##########
@@ -144,7 +174,7 @@ def download(url, path=None, overwrite=False):
else:
fname = path
- if overwrite or not os.path.exists(fname):
+ if overwrite or not os.path.exists(fname) or not sha1hex or not
verified_sha1(fname, sha1hex):
Review comment:
this means always overwrite when sha1hex is None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
