piiswrong commented on a change in pull request #7347: Tensorcore conv deconv 
support
URL: https://github.com/apache/incubator-mxnet/pull/7347#discussion_r132088433
 
 

 ##########
 File path: src/operator/cudnn_algoreg-inl.h
 ##########
 @@ -40,12 +65,17 @@ class CuDNNAlgoReg {
     oss << "cudnn_data_type=" << cudnn_data_type << ";";
     oss << "cudnn_forward_compute_type=" << cudnn_forward_compute_type << ";";
     oss << "cudnn_backward_compute_type=" << cudnn_backward_compute_type << 
";";
+    // A system could be heterogeneous and thus have different algo choices 
for different
+    // device ids.  'device_id' could possibly be replaced with gpu compute 
capability,
+    // but identical GPUs could technically have different clock settings.
+    oss << "device_id=" << device_id << ";";
 
 Review comment:
   Let's ignore clock setting for now and use compute capability
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to