piiswrong commented on a change in pull request #7393: add depthwise 
convolution's gpu version optimization
URL: https://github.com/apache/incubator-mxnet/pull/7393#discussion_r132094688
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -955,6 +955,40 @@ def test_convolution_grouping():
     for arr1, arr2 in zip(exe1.outputs + exe1.grad_arrays, exe2.outputs + 
exe2.grad_arrays):
         np.testing.assert_allclose(arr1.asnumpy(), arr2.asnumpy(), rtol=1e-3, 
atol=1e-4)
 
+def test_depthwise_convolution():
 
 Review comment:
   Actually, this is fine. please reduce 224 to something like 32 or 64 and 
test for 2 or 3 more configs. Like differetn num_base and kernal_size/pad/stride
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to