eric-haibin-lin commented on a change in pull request #7390: adding ranking 
metrics (precision/recall) at position K. 
URL: https://github.com/apache/incubator-mxnet/pull/7390#discussion_r132746805
 
 

 ##########
 File path: python/mxnet/ranking_metrics.py
 ##########
 @@ -0,0 +1,46 @@
+"""
 
 Review comment:
   I don't think it's a good idea adding this as a standalone file under 
`python/mxnet`. Is it more reasonable to put integrate this metric in 
`python/mxnet/metric.py` file? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to