eric-haibin-lin commented on a change in pull request #7082: Sparse Tensor:
request for reviews
URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r133617511
##########
File path: python/mxnet/model.py
##########
@@ -113,25 +127,36 @@ def _update_params_on_kvstore(param_arrays, grad_arrays,
kvstore, param_names):
# push gradient, priority is negative index
kvstore.push(name, grad_list, priority=-index)
# pull back the weights
- kvstore.pull(name, arg_list, priority=-index)
+ if _contains_non_default_storage(arg_list):
Review comment:
Normally given a key, the ndarrays in the arg_list will be either all dense
or all sparse, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
