jeremiedb commented on issue #7476: R-package RNN refactor
URL: https://github.com/apache/incubator-mxnet/pull/7476#issuecomment-325228128
 
 
   Improve the harmonization with model.FeedForward: same fixed.params, 
arg.params and aux.params input arguments. 
   
   Remove redundancies between model.buckets and model.train.buckets. 
   
   model.buckets is as performant on single symbol model as model.Feedforward. 
If using BatchNorm, single symbol works fine but the still is issue if training 
on list of symbols. 
   
   Comment out the lstm in testthat to pass CI.
   
   Integrate CPU compatible RNN construction with raw lstm and gru cells in 
rnn.graph. No support for masking. Still need to test efficiency of inference 
and potentially adapt the inference functions. 
   
   Unsure if wouldn't be preferable to assume a batch.size X seq.length input 
dimension to interator as it's the format expectged by symnol.RNN cell. Or add 
a shape detector to handle it automatically as in the python API. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to