cjolivier01 commented on a change in pull request #7782: Scala fix
URL: https://github.com/apache/incubator-mxnet/pull/7782#discussion_r137639450
##########
File path: src/operator/spatial_transformer.cc
##########
@@ -27,8 +27,8 @@
namespace mshadow {
template<typename DType>
-bool between(DType value, int lowerBound, int upperBound) {
- return (value >= lowerBound && value <= upperBound);
+static MSHADOW_CINLINE bool between(const DType value, const DType lowerBound,
const DType upperBound) {
Review comment:
because this function is used only in this file. static avoids link
collisions with other object files which may have the same function defined.
Since its prototype is not declared outside this file, then by convention, it
should be declared as static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
