rahul003 commented on a change in pull request #7782: Scala fix
URL: https://github.com/apache/incubator-mxnet/pull/7782#discussion_r137640160
##########
File path: src/operator/spatial_transformer.cc
##########
@@ -27,8 +27,8 @@
namespace mshadow {
template<typename DType>
-bool between(DType value, int lowerBound, int upperBound) {
- return (value >= lowerBound && value <= upperBound);
+static MSHADOW_CINLINE bool between(const DType value, const DType lowerBound,
const DType upperBound) {
Review comment:
https://github.com/apache/incubator-mxnet/blob/master/src/operator/bilinear_sampler.cc#L30
Just to add context, similar function is defined again in the above file.
There is no difference in the functions but is defined again. Should we change
them to use the same function?
EDIT: Oops we commented at the same time Chris.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
