eric-haibin-lin commented on a change in pull request #7720: [sparse] add ftrl
optimizer for sparse
URL: https://github.com/apache/incubator-mxnet/pull/7720#discussion_r137959958
##########
File path: src/operator/optimizer_op.cu
##########
@@ -51,5 +51,9 @@ NNVM_REGISTER_OP(rmsprop_update)
NNVM_REGISTER_OP(rmspropalex_update)
.set_attr<FCompute>("FCompute<gpu>", RMSPropAlexUpdate<gpu>);
+NNVM_REGISTER_OP(ftrl_update)
+.set_attr<FCompute>("FCompute<gpu>", FtrlUpdate<gpu>)
+.set_attr<FComputeEx>("FComputeEx<gpu>", FtrlUpdateEx<gpu>);
Review comment:
Are you suggesting removing `FCompute<gpu>` for Ftrl op? If we remove
`FtrlUpdate<gpu>` from the op registration it will break backward compatibility
and affect other people who are using it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
