szha commented on a change in pull request #7931: MKL-DNN integration: request for reviews URL: https://github.com/apache/incubator-mxnet/pull/7931#discussion_r139510706
########## File path: src/operator/lrn.cc ########## @@ -40,6 +46,9 @@ Operator* CreateOp<cpu>(LRNParam param, int dtype) { #if MXNET_USE_MKL2017 == 1 return new MKLLRNOp<cpu, float>(param); #endif +#if MXNET_USE_MKLDNN == 1 + return new MKLDNNLRNOp<cpu, float>(param); Review comment: If both MKL2017 and MKLDNN are on, this would become dead code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services