jmerkow commented on a change in pull request #7949: account for batch padding 
when updating metrics
URL: https://github.com/apache/incubator-mxnet/pull/7949#discussion_r140069817
 
 

 ##########
 File path: python/mxnet/module/executor_group.py
 ##########
 @@ -400,6 +414,12 @@ def forward(self, data_batch, is_train=None):
 
         """
         _load_data(data_batch, self.data_arrays, self.data_layouts)
+
+        if hasattr(data_batch, 'pad'):
 
 Review comment:
   You can replace this with `self.cur_batch_pad = getattr(data_batch, 'pad', 
None)`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to