piiswrong commented on a change in pull request #7947: [WIP] Refactor infer
storage function for sparse operators.
URL: https://github.com/apache/incubator-mxnet/pull/7947#discussion_r140917912
##########
File path: src/executor/graph_executor.cc
##########
@@ -575,7 +582,8 @@ void GraphExecutor::Init(nnvm::Symbol symbol,
g.GetAttr<nnvm::DTypeVector>("dtype"));
}
- g = InferStorageType(std::move(g), std::move(arg_stypes),
"__storage_type__");
+ g.attrs["storage_type"] = std::make_shared<dmlc::any>(std::move(arg_stypes));
+ g = InferStorageType(std::move(g), std::move(StorageTypeVector()), "");
Review comment:
move is unnecessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
