reminisce commented on a change in pull request #7947: [WIP] Refactor infer 
storage function for sparse operators.
URL: https://github.com/apache/incubator-mxnet/pull/7947#discussion_r140953273
 
 

 ##########
 File path: src/executor/infer_graph_attr_pass.cc
 ##########
 @@ -35,7 +36,8 @@ bool ApplyOpInferAttr(const nnvm::Graph& g,
                       const NodeAttrs& attrs,
                       const uint32_t nid,
                       std::vector<AttrType>* in_attrs,
-                      std::vector<AttrType>* out_attrs) {
+                      std::vector<AttrType>* out_attrs,
+                      int*) {
 
 Review comment:
   It'd better not leave the argument name empty. How about naming it 
`aux_attr`?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to