tlby commented on a change in pull request #8015: [Perl] Adding Gluon interface
to Perl, miscellaneous changes in order to sync with Python
URL: https://github.com/apache/incubator-mxnet/pull/8015#discussion_r141493129
##########
File path: perl-package/AI-MXNet/lib/AI/MXNet/Logging.pm
##########
@@ -17,8 +17,11 @@
package AI::MXNet::Logging;
## TODO
+use strict;
+use warnings;
use Mouse;
-sub warning { shift; warn sprintf(shift, @_) . "\n" };
+$AI::MXNet::Logging::silent = 0;
Review comment:
`our $silent = 0;` would achieve the same thing here, and then uses of the
variable in this package wouldn't need to be fully qualified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
