sergeykolychev commented on a change in pull request #8015: [Perl] Adding Gluon
interface to Perl, miscellaneous changes in order to sync with Python
URL: https://github.com/apache/incubator-mxnet/pull/8015#discussion_r141498829
##########
File path: perl-package/AI-MXNet/lib/AI/MXNet/Symbol/NameManager.pm
##########
@@ -75,10 +75,10 @@ method get(Maybe[Str] $name, Str $hint)
method current()
{
- $AI::MXNet::current_nm_ldr;
+ $mx::NameManager;
}
-$AI::MXNet::current_nm_ldr = __PACKAGE__->new;
+$mx::NameManager = __PACKAGE__->new;
Review comment:
This var is sometimes exposed to user asking them to alter default naming
pattern via
local($mx::NameManager) = mx->name->Prefix("prefix_");
This is consistent with local($mx::AttrScope) = mx->AttrScope(...);
and local($mx::Context) = mx->gpu(1);
which is in its turn consistent with the python examples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
