ptrendx commented on a change in pull request #16391: cuDNN non-persistant 
bidirectional RNN dgrad sync fix
URL: https://github.com/apache/incubator-mxnet/pull/16391#discussion_r332754245
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -149,6 +149,9 @@ def test_lstm_bidirectional():
     check_rnn_consistency(fused, stack, T, N, I, H, 'write')
     check_rnn_consistency(fused, stack, T, N, I, H, 'add')
     check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+    # Repeated to expose low-probability failure in cuDNN v7.6.4 and earlier
 
 Review comment:
   You can probably take it out now, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to