drivanov commented on a change in pull request #16398: Aggregated adamw update
URL: https://github.com/apache/incubator-mxnet/pull/16398#discussion_r332775461
##########
File path: src/operator/contrib/adamw-inl.h
##########
@@ -151,7 +135,7 @@ struct MPAdamWUpdate {
const std::vector<TBlob> &outputs,
const float rescale_grad) {
using namespace mxnet_op;
- AdamWParam param = nnvm::get<AdamWParam>(attrs.parsed);
+ const auto ¶m = nnvm::get<AdamWParam>(attrs.parsed);
Review comment:
I could do that, but it does not look like a standard for the whole MxNet,
perhaps, just for `adamw-inl.h`. I searched for `auto &` and `auto&` in all
`*h, *.cc, *.cu` files. As I could see, the probability of this or that option
is approximately 50%.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
