DickJC123 opened a new issue #16474: CI has pylint's cyclic-import error disabled. Worth fixing? URL: https://github.com/apache/incubator-mxnet/issues/16474 Issue https://github.com/apache/incubator-mxnet/issues/16401 and resulting PR https://github.com/apache/incubator-mxnet/pull/16462 exposed the fact by running pylint with the arg `--jobs=8`, our CI experienced the following behaviors: - Some classes of errors were not being reported (cyclic-import, duplicate-code, too-many-lines) - Some errors were being flagged non-deterministically (import-outside-toplevel) PR https://github.com/apache/incubator-mxnet/pull/16462 returned the CI's use of pylint to deterministic behavior by setting `--jobs=1` and correcting the one import-outside-toplevel error signaled solidly in that mode. The PR also disabled the 3 error classes cyclic-import, duplicate-code, too-many-lines, hopefully pending a more in-depth study. As asked by @marcoabreu , "Do we want to analyze and fix the cyclic-import errors?" I hope one of the major python code owners might like to take up this question. The errors can be seen in: http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-16462/1/pipeline A PR to address this would start by removing `cyclic-import` from the list of disabled checks in ./ci/other/pylintrc. @szha @reminisce @stu1130 @larroy For Q & A and discussion, please start a discussion thread at https://discuss.mxnet.io
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
