TaoLv opened a new pull request #16555: Upgrade MKL-DNN dependency to v1.0 URL: https://github.com/apache/incubator-mxnet/pull/16555 ## Description ## This is an effort from the whole Intel MXNet team. Credits belong to everyone in the team. This PR upgrades the 3rdparty/mkldnn dependency to it's v1.0.x release which has many API breaking changes and is not backward compatible to the previous v0.x versions. Hence this PR also changes the integration code in operators while keep the integration methodology and software architecture the same. Development has been done on the feature branch `mkldnn-v1.0` and tracked via github project: https://github.com/apache/incubator-mxnet/projects/16. Please see the discussion here: https://lists.apache.org/thread.html/f46ab920f18795496eafe713e6e9e561c684e06189085cec17b401dc@%3Cdev.mxnet.apache.org%3E Please see MKL-DNN v1.0 RFC here: https://github.com/intel/mkl-dnn/tree/rfc-api-changes-v1.0/doc/rfc/api-v1.0 As mentioned in the dev@ thread, this PR also removes the mklml and iomp5 library which previously are distributed along with MXNet pip package. So it also fixes the license issue in https://github.com/apache/incubator-mxnet/issues/15544. It's a requirement for 1.6.0 release. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
